🐛 Fix flaky tests #258
Closed
🐛 Fix flaky tests #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Guettler <[email protected]>
Signed-off-by: Thomas Guettler <[email protected]>
Signed-off-by: Thomas Guettler <[email protected]>
Signed-off-by: Thomas Guettler <[email protected]>
Signed-off-by: Thomas Guettler <[email protected]>
Signed-off-by: Thomas Guettler <[email protected]>
Signed-off-by: Thomas Guettler <[email protected]>
Signed-off-by: Thomas Guettler <[email protected]>
Signed-off-by: Thomas Guettler <[email protected]>
|
Hi @guettli and @janiskemper is this still important? |
|
@jschoone I think this PR looks mostly also like some exploration and debugging. It will have nothing to do with the current CI failures. I also saw three different errors in the CI for linting of Go and yaml, as well as the integration tests. Tbh I have no idea. It would probably require going in depth through the past commits (mostly updates of the bot) to see whether there is anything interesting. |
|
@jschoone @janiskemper I think the PR can be closed. It is too old. Please re-open if you want to keep it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The tests are flaky. This is easy to reproduce. CI often fails and re-running the tests usually solve the issue.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #257
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: